WIP: Troubleshooting ModBus bit_sensor#2
Closed
yury-sannikov wants to merge 2 commits intodevfrom
Closed
Conversation
janiversen
reviewed
Apr 2, 2021
| ) | ||
| import homeassistant.helpers.config_validation as cv | ||
|
|
||
| from .bit_sensor import CONF_BIT_SENSORS |
There was a problem hiding this comment.
Const belong in const.py (you might have created a round-around-robin here)
janiversen
reviewed
Apr 2, 2021
| from .const import CALL_TYPE_COIL, CONF_INPUT_TYPE, MODBUS_DOMAIN | ||
| from .modbus import ModbusHub | ||
|
|
||
| CONF_BIT_SENSORS = "bit_sensors" |
janiversen
reviewed
Apr 2, 2021
| _LOGGER = logging.getLogger(__name__) | ||
|
|
||
|
|
||
| async def async_setup_platform( |
There was a problem hiding this comment.
This will not be called, unless you add BIT_SENSOR/BIT_SENSORS to the loop in modbus.py (look for e.g. CLIMATE)
|
There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm trying to add a
bit_sensorin addition to thebinary_sensorWhat I did:
CONF_BIT_SENSORSconstantCONF_BIT_SENSORSas anarray_name_discoveryI do not see that
async_setup_platformmethod of the bit_sensor.py file called.My goal is to make bit_sensor work side-by-side with the binary_sensor.